Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup acceptance tests workflow #2529

Merged
merged 1 commit into from
May 28, 2024

Conversation

isavov
Copy link
Contributor

@isavov isavov commented May 23, 2024

Description:
This PR removes a workaround that has become unnecessary with the latest versions of hedera-local-node

Related issue(s):

Fixes #2501

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
@isavov isavov linked an issue May 23, 2024 that may be closed by this pull request
Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Acceptance Tests

  17 files  244 suites   30m 5s ⏱️
590 tests 584 ✔️ 3 💤 3
819 runs  806 ✔️ 7 💤 6

Results for commit cb27c6a.

Copy link

Tests

    2 files  149 suites   13s ⏱️
833 tests 832 ✔️ 1 💤 0
845 runs  844 ✔️ 1 💤 0

Results for commit cb27c6a.

@isavov isavov marked this pull request as ready for review May 23, 2024 11:59
@isavov isavov requested a review from a team as a code owner May 23, 2024 11:59
@isavov isavov requested a review from acuarica May 23, 2024 11:59
@isavov isavov self-assigned this May 23, 2024
@isavov isavov added the process Build, test and deployment-process related tasks label May 23, 2024
Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isavov isavov merged commit 9030cb4 into main May 28, 2024
34 checks passed
@isavov isavov deleted the 2501-cleanup-acceptance-tests-workflow branch May 28, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
process Build, test and deployment-process related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup Acceptance tests workflow
3 participants