Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter API in JSON-RPC Relay #775

Merged
merged 4 commits into from
Sep 6, 2023
Merged

Filter API in JSON-RPC Relay #775

merged 4 commits into from
Sep 6, 2023

Conversation

georgi-l95
Copy link
Contributor

This HIP proposes adding Filter API to the JSON-RPC Relay

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

draft filter api hip

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

add hip number

Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@netlify
Copy link

netlify bot commented Aug 2, 2023

Deploy Preview for hedera-hips ready!

Name Link
🔨 Latest commit a1000d9
🔍 Latest deploy log https://app.netlify.com/sites/hedera-hips/deploys/64f8b6b7efa5440008b2c8ed
😎 Deploy Preview https://deploy-preview-775--hedera-hips.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@stoqnkpL stoqnkpL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, tyvm @georgi-l95 !


The JSON-RPC Relay enables clients to query for particular events, but they have to provide new params on every request.

Currently, in order to retrieve newly created contract logs developers need to constantly query the `eth_getLogs` method. This requires custom logic on developer side, to provide new parameters for this events on every poll.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't eth_subscribe an alternative to constantly querying as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is. If you don't want to use websocket, this is the way.

Signed-off-by: georgi-l95 <glazarov95@gmail.com>
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95 georgi-l95 marked this pull request as ready for review August 17, 2023 12:34
Signed-off-by: Michael Garber <michael.garber@swirldslabs.com>
@mgarbs mgarbs merged commit bde7400 into hashgraph:main Sep 6, 2023
6 checks passed
kimbor pushed a commit to kimbor/hedera-improvement-proposal that referenced this pull request Jun 24, 2024
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
Signed-off-by: Michael Garber <michael.garber@swirldslabs.com>
Co-authored-by: Michael Garber <michael.garber@swirldslabs.com>
Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants