Skip to content

Commit

Permalink
Address some feedback
Browse files Browse the repository at this point in the history
Signed-off-by: Steven Sheehy <steven.sheehy@swirldslabs.com>
  • Loading branch information
steven-sheehy committed Mar 22, 2023
1 parent b57df86 commit 658b4c8
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions HIP/HIP-668.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ external members of the Hedera community.
The main goal of the mirror node GraphQL API is to expose data customers need in the format they require. It
should take the current REST API as inspiration and expose a similar set of data but in a format more suitable for
GraphQL. Data should be nested and allow for pagination at different levels. Strongly typed objects should be preferred
over complex string representations of multi-field objects similar to the protobuf-based HAPI. For example, the
transaction ID `0.0.289304-1673028763-068736176` in the current API could be a GraphQL type `TransactionId` with
over complex string representations of multi-field objects similar to the protobuf-based HAPI. For example, instead of
the transaction ID being a string as in the REST API, it could be a GraphQL type `TransactionId` with
`nonce`, `payerAccountId`, `scheduled`, and `validStart` fields where even those could be complex types.

An existing GraphQL API for the Hedera network was created by community members under the name
Expand Down Expand Up @@ -89,7 +89,7 @@ calls with one GraphQL call.

The new GraphQL API will be written as a new module in the open source Hedera Mirror Node repository. It will be Java
based to allow for code reuse with its other modules. It will interact directly with the SQL database like the other
modules. Creating it as separate module will allow it to be a microservice that can be scaled separately from other
modules. Creating it as a separate module will allow it to be a microservice that can be scaled separately from other
components to auto-scale based upon load. The API will be defined in a contract-first manner using the GraphQL schema
files defined in the following sections. The view model will be auto-generated from the schema using a Gradle plugin.

Expand Down Expand Up @@ -569,7 +569,6 @@ The unique identifier to find a specific account. Only one of the given fields c
error will occur.
"""
input AccountIdInput {

"A RFC 4648 Base32 encoded string with the trailing '=' characters removed that represents an account alias."
alias: String @Pattern(regexp: "^[A-Z2-7]+$")

Expand Down Expand Up @@ -1200,6 +1199,9 @@ input ContractResultId {
"The unique consensus timestamp at which this contract execution occurred."
timestamp: Timestamp

"The 32 byte transaction hash"
transactionHash: String @Pattern(regexp: "^(0x)?[a-fA-F0-9]{64}$")

"The client generated identifier associated with this transaction."
transactionId: TransactionIdInput
}
Expand Down

0 comments on commit 658b4c8

Please sign in to comment.