Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CN2BN Part 1 - Verification HappyPath and VerificationFailed #552

Closed
wants to merge 34 commits into from

Conversation

AlfredoG87
Copy link
Contributor

Description:
This PR introduces support the following CN 2 BN communication scenarios:

When CN sends the expected block
When CN sends the expected block but fails verification

Related issue(s):

Fixes #519

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

… fashion.

Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
…on blockHash Verification using the signature of the blockProof instead of the prevHash of the next block and general improvements

Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
…f directly sending items to the notifier

Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
… as is the first block on the blockNode, once the blockNode has its own state and configuration, it will have to start from that one.

Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
… of the blockHash

Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
@AlfredoG87 AlfredoG87 added this to the 0.4.0 milestone Jan 28, 2025
@AlfredoG87 AlfredoG87 added Block Node Issues/PR related to the Block Node. New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. labels Jan 28, 2025
@AlfredoG87 AlfredoG87 self-assigned this Jan 28, 2025
@AlfredoG87 AlfredoG87 marked this pull request as ready for review January 28, 2025 20:00
@AlfredoG87 AlfredoG87 requested a review from a team as a code owner January 28, 2025 20:00
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
@AlfredoG87 AlfredoG87 changed the title feat: CN2BN Part 1 - Verification HappyPath and Verification Failed feat: CN2BN Part 1 - Verification HappyPath and VerificationFailed Jan 28, 2025
@AlfredoG87 AlfredoG87 closed this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Block Node Issues/PR related to the Block Node. New Feature A new feature, service, or documentation. Major changes that are not backwards compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Block Acknowledgement from BN to CN
1 participant