Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement support for the install command returning a Release object #87

Merged
merged 3 commits into from
Jun 15, 2023

Conversation

jeromy-cannon
Copy link
Contributor

closed #83

@jeromy-cannon jeromy-cannon self-assigned this Jun 9, 2023
@jeromy-cannon jeromy-cannon marked this pull request as draft June 9, 2023 20:48
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07 🎉

Comparison is base (7496bd3) 51.72% compared to head (014adc5) 51.79%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #87      +/-   ##
============================================
+ Coverage     51.72%   51.79%   +0.07%     
- Complexity      134      139       +5     
============================================
  Files            32       36       +4     
  Lines           667      668       +1     
  Branches         74       73       -1     
============================================
+ Hits            345      346       +1     
  Misses          290      290              
  Partials         32       32              
Impacted Files Coverage Δ
...ient/model/install/InstallChartOptionsBuilder.java 100.00% <ø> (ø)
...a/com/hedera/fullstack/helm/client/HelmClient.java 100.00% <100.00%> (ø)
.../fullstack/helm/client/impl/DefaultHelmClient.java 70.00% <100.00%> (-2.10%) ⬇️
...a/fullstack/helm/client/model/chart/ChartInfo.java 100.00% <100.00%> (ø)
...llstack/helm/client/model/chart/ChartMetadata.java 100.00% <100.00%> (ø)
...era/fullstack/helm/client/model/chart/Release.java 100.00% <100.00%> (ø)
...fullstack/helm/client/model/chart/ReleaseInfo.java 100.00% <100.00%> (ø)
...helm/client/model/install/InstallChartOptions.java 83.78% <100.00%> (-0.43%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jeromy-cannon jeromy-cannon force-pushed the 00083-helm-install-release-obj branch from ef7673e to a077a13 Compare June 12, 2023 16:37
@github-actions
Copy link

github-actions bot commented Jun 12, 2023

Unit Test Results

35 tests   - 1   32 ✔️  - 1   28s ⏱️ -2s
  8 suites +1     3 💤 ±0 
  8 files   +1     0 ±0 

Results for commit 014adc5. ± Comparison against base commit 7496bd3.

This pull request removes 9 and adds 8 tests. Note that renamed tests count towards both.
com.hedera.fullstack.helm.client.test.HelmClientTest ‑ [10] Install Chart From Repository
com.hedera.fullstack.helm.client.test.HelmClientTest ‑ [11] Install Chart Skipping CRDs
com.hedera.fullstack.helm.client.test.HelmClientTest ‑ [12] Install Chart with Timeout
com.hedera.fullstack.helm.client.test.HelmClientTest ‑ [13] Install Chart with Username
com.hedera.fullstack.helm.client.test.HelmClientTest ‑ [14] Install Chart with Specific Version
com.hedera.fullstack.helm.client.test.HelmClientTest ‑ [15] Install Chart with Wait
com.hedera.fullstack.helm.client.test.HelmClientTest ‑ [7] Install Chart with Tabular Output
com.hedera.fullstack.helm.client.test.HelmClientTest ‑ [8] Install Chart with JSON Output
com.hedera.fullstack.helm.client.test.HelmClientTest ‑ [9] Install Chart with Password
com.hedera.fullstack.helm.client.test.HelmClientTest ‑ [10] Install Chart with Timeout
com.hedera.fullstack.helm.client.test.HelmClientTest ‑ [11] Install Chart with Username
com.hedera.fullstack.helm.client.test.HelmClientTest ‑ [12] Install Chart with Specific Version
com.hedera.fullstack.helm.client.test.HelmClientTest ‑ [13] Install Chart with Wait
com.hedera.fullstack.helm.client.test.HelmClientTest ‑ [7] Install Chart with Password
com.hedera.fullstack.helm.client.test.HelmClientTest ‑ [8] Install Chart From Repository
com.hedera.fullstack.helm.client.test.HelmClientTest ‑ [9] Install Chart Skipping CRDs
com.hedera.fullstack.helm.client.test.model.chart.ReleaseTest ‑ Test Deserializing JSON Release Response

♻️ This comment has been updated with latest results.

@jeromy-cannon jeromy-cannon force-pushed the 00083-helm-install-release-obj branch from edc9397 to 1994fc6 Compare June 12, 2023 18:57
…install

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
…nse from install

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon jeromy-cannon force-pushed the 00083-helm-install-release-obj branch from 1994fc6 to 014adc5 Compare June 12, 2023 19:13
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@jeromy-cannon jeromy-cannon marked this pull request as ready for review June 12, 2023 21:12
@jeromy-cannon jeromy-cannon merged commit 6815e03 into main Jun 15, 2023
@jeromy-cannon jeromy-cannon deleted the 00083-helm-install-release-obj branch June 15, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm Client: Implement support for the install command returning a Release object
2 participants