fix: set network node service as a headless service to support FQDN on GKE #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in order for config.txt/address book to work correctly with the current solo logic. Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
jeromy-cannon
requested review from
leninmehedy,
nathanklick,
JeffreyDallas and
rbarkerSL
rbarkerSL
approved these changes
May 15, 2024
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #849 +/- ##
=========================================
Coverage 67.17% 67.17%
Complexity 339 339
=========================================
Files 64 64
Lines 1319 1319
Branches 157 157
=========================================
Hits 886 886
Misses 370 370
Partials 63 63 |
swirlds-automation
added a commit
that referenced
this pull request
May 16, 2024
## [0.25.0](v0.24.5...v0.25.0) (2024-05-16) ### Features * add conditional configMap and secret volumeMounts to `fullstack-deployment` helm chart ([#797](#797)) ([ed3c16d](ed3c16d)) ### Bug Fixes * set network node service as a headless service to support FQDN on GKE ([#849](#849)) ([9ac3c35](9ac3c35))
|
🎉 This PR is included in version 0.25.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request changes the following:
Related Issues