Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): check if node is ACTIVE after it is started #616

Merged
merged 9 commits into from
Dec 11, 2023
Merged

fix(cli): check if node is ACTIVE after it is started #616

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
eb340e0
feat: temp commit to create test account after node start
leninmehedy Dec 5, 2023
93b7fa4
feat: implement e2e test for node
leninmehedy Dec 6, 2023
6576e5f
fix cleaning up kubctl port-forward processes
leninmehedy Dec 7, 2023
d1273c6
fix: check node is in ACTIVE state before making any transaction or q…
leninmehedy Dec 7, 2023
4e21148
test: tidy up test and add debug logs
leninmehedy Dec 8, 2023
d1e7710
style: fix indentation and apply format
leninmehedy Dec 8, 2023
4f109f5
ci: fix error
leninmehedy Dec 8, 2023
ed0db38
fix: increase max attempt for node ACTIVE check
leninmehedy Dec 8, 2023
6923034
Merge branch 'main' into 515-node-start-e2e-test
leninmehedy Dec 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
style: fix indentation and apply format 
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
  • Loading branch information
@leninmehedy
leninmehedy committed Dec 8, 2023
commit d1e7710a491aecc87510ad3c54783f88c0987361
8 changes: 7 additions & 1 deletion fullstack-network-manager/src/commands/node.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,13 @@ export class NodeCommand extends BaseCommand {
const podName = Templates.renderNetworkPodName(nodeId)

try {
await this.kubectl.wait('pod', '--for=jsonpath=\'{.status.phase}\'=Running', '-l fullstack.hedera.com/type=network-node', `-l fullstack.hedera.com/node-name=${nodeId}`, '--timeout=300s', `-n "${namespace}"`)
await this.kubectl.wait('pod',
'--for=jsonpath=\'{.status.phase}\'=Running',
'-l fullstack.hedera.com/type=network-node',
`-l fullstack.hedera.com/node-name=${nodeId}`,
'--timeout=300s',
`-n "${namespace}"`
)

return podName
} catch (e) {
Expand Down
8 changes: 4 additions & 4 deletions fullstack-network-manager/test/unit/core/shell_runner.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ describe('ShellRunner', () => {
it('should run command', async () => {
await shellRunner.run('ls -l')
expect(loggerSpy).toHaveBeenNthCalledWith(1, 'Executing command: \'ls -l\'')
expect(loggerSpy).toHaveBeenNthCalledWith(2,'Finished executing: \'ls -l\'', {
'commandExitCode': expect.any(Number),
'commandExitSignal': null,
'commandOutput': expect.any(Array)
expect(loggerSpy).toHaveBeenNthCalledWith(2, 'Finished executing: \'ls -l\'', {
commandExitCode: expect.any(Number),
commandExitSignal: null,
commandOutput: expect.any(Array)
})
expect(readableSpy).toHaveBeenCalledWith('data', expect.anything())
expect(childProcessSpy).toHaveBeenCalledWith('exit', expect.anything())
Expand Down