Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use NMT to install and start network nodes #178

Merged
merged 44 commits into from
Jul 27, 2023

Conversation

leninmehedy
Copy link
Member

@leninmehedy leninmehedy commented Jul 13, 2023

Description

This pull request adds scripts to install and run network node using NMT. This ensures we have a working hedera-network-nodes using helm chart.

It also includes some Dockerfile and keys that are needed to start the node in the /dev directory. I also added a Makefile and README in /dev directory describing how to start the node. We may update the README in the root directory later once it is more polished.

Notes

  • It requires gsutil to fetch required resources from fst-resources bucket (I created it recently and uploaded the resources. This may become obsolete, but for now this helps to ensure all required resources are in one place and it can be accessed using a single tool gsutil)
  • It assumes docker desktop is running with generous amount of resources(CPU 6 core, 16Gb RAM, 2GB Swap, 200Gb disk etc.)
  • It assumes kind, helm and kubectl CLI programs are installed

Related Issues

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@github-actions
Copy link

github-actions bot commented Jul 13, 2023

Unit Test Results

38 tests  ±0   35 ✔️ ±0   31s ⏱️ -1s
  9 suites ±0     3 💤 ±0 
  9 files   ±0     0 ±0 

Results for commit 82e591b. ± Comparison against base commit c3f800a.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #178 (82e591b) into main (c3f800a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #178   +/-   ##
=========================================
  Coverage     56.70%   56.70%           
  Complexity      144      144           
=========================================
  Files            36       36           
  Lines           723      723           
  Branches         73       73           
=========================================
  Hits            410      410           
  Misses          281      281           
  Partials         32       32           

Impacted file tree graph

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy leninmehedy marked this pull request as ready for review July 18, 2023 11:09
@leninmehedy leninmehedy requested review from nathanklick and deepak-swirlds and removed request for nathanklick July 18, 2023 11:09
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy leninmehedy requested a review from nathanklick July 18, 2023 11:59
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy leninmehedy marked this pull request as draft July 18, 2023 12:39
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

# Conflicts:
#	charts/hedera-network/configs/test.sh
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy leninmehedy marked this pull request as ready for review July 27, 2023 12:31
@leninmehedy leninmehedy changed the title feat: use NMT to install and run network node feat: use NMT to install and start network nodes Jul 27, 2023
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick nathanklick force-pushed the 176-use-nmt-to-install-node-software branch from 12ab02e to 82e591b Compare July 27, 2023 14:33
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nathanklick nathanklick merged commit f96519e into main Jul 27, 2023
@nathanklick nathanklick deleted the 176-use-nmt-to-install-node-software branch July 27, 2023 14:40
swirlds-automation added a commit that referenced this pull request Jul 31, 2023
## [0.4.0](v0.3.0...v0.4.0) (2023-07-31)

### Features

* adds OFAC block list & switch to haproxy version 2.4 ([#183](#183)) ([0b57e15](0b57e15))
* custom k8s label needs fullstack.hedera.com/ prefix ([#195](#195)) ([c3f800a](c3f800a))
* install network node software without nmt ([#197](#197)) ([b1029ea](b1029ea))
* use NMT to install and start network nodes ([#178](#178)) ([f96519e](f96519e))

### Bug Fixes

* resolve build issue with ubi8-init-java17 container image ([#201](#201)) ([9bc93c3](9bc93c3))
* update helm chart to align with design and flexibility requirements ([#198](#198)) ([6ca10ee](6ca10ee))
* update values file to remove configurable hedera UID/GID properties ([#173](#173)) ([be14c1e](be14c1e))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Charts[Network Node]: Use NMT To Install Node Software In ubi8-init-dind Root Container
3 participants