Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charts[Network Node]: Update verification script so that CI pipelines fail if node fails to start #248

Closed
Tracked by #111
leninmehedy opened this issue Aug 4, 2023 · 2 comments · Fixed by #254
Closed
Tracked by #111

Charts[Network Node]: Update verification script so that CI pipelines fail if node fails to start #248

leninmehedy opened this issue Aug 4, 2023 · 2 comments · Fixed by #254
Assignees
@leninmehedy
Labels
Bug A error that causes the feature to behave differently than what was expected based on design docs released on @0.5.x released
Milestone
v0.5.0

Comments

@leninmehedy
Copy link
Member

Currently CI pipeline succeeds even if node failed to start. This seems to be because the "verify_node" function is not returning error or the error is not handled properly.
@leninmehedy leninmehedy self-assigned this Aug 4, 2023
@leninmehedy leninmehedy moved this to 🔖 Ready in FST Suite Aug 4, 2023
@leninmehedy leninmehedy moved this from 🔖 Ready to 🏗 In progress in FST Suite Aug 4, 2023
@nathanklick nathanklick mentioned this issue Aug 4, 2023
Open
@nathanklick nathanklick added the Bug A error that causes the feature to behave differently than what was expected based on design docs label Aug 4, 2023
@nathanklick nathanklick added this to the v0.5.0 milestone Aug 4, 2023
leninmehedy added a commit that referenced this issue Aug 6, 2023
@leninmehedy
ci: ensure helm test failure fails the pipeline while also cleaning u…
be0e100 
…p the test network

closes #248

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy leninmehedy linked a pull request Aug 6, 2023 that will close this issue
fix: update verification script so that CI pipeline fails if node fails to start #254
Merged
@leninmehedy leninmehedy mentioned this issue Aug 6, 2023
Merged
@leninmehedy leninmehedy moved this from 🏗 In progress to 👀 In review in FST Suite Aug 6, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in FST Suite Aug 7, 2023
@swirlds-automation
Copy link
Contributor

🎉 This issue has been resolved in version 0.5.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@swirlds-automation
Copy link
Contributor

🎉 This issue has been resolved in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leninmehedy leninmehedy

Labels
Bug A error that causes the feature to behave differently than what was expected based on design docs released on @0.5.x released
Projects
FST Suite
Status: ✅ Done
Milestone
v0.5.0
3 participants
@leninmehedy @nathanklick @swirlds-automation