Skip to content

Conversation

@jenlampton
Copy link

@jenlampton jenlampton commented Aug 15, 2022

Fixes #3133

Summary

  • Switched placeholder text from value attribute to placeholder attribute on input element.

Please double-check that:

  • All changes were made in CoffeeScript files, not JavaScript files.
  • You used Grunt to build the JavaScript files and tested them locally.
  • You've updated both the jQuery and Prototype versions.
  • You haven't manually updated the version number in package.json.
  • N/A If necessary, you've updated the documentation.

See the Pull Requests section of our Contributing Guidelines for more details.

References

If your pull request is in reference to one or more open GitHub issues, please mention them here to keep the conversations linked together:

@jenlampton
Copy link
Author

jenlampton commented Aug 15, 2022

The command npm install failed with the error The package-lock.json file was created with an old version of npm and a handful of deprecations, so I was not able to use Grunt to build the JavaScript files.

To test locally, I modified the chosen.jquery.js file directly since the change was very simple.

If someone else can get grunt working with the latest version of chosen, I could use some help with the build process for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use placeholder attribute on input elements for placeholder text (instead of value attribute)

1 participant