controller/blockdevice: should update DevPath once it changed #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the issue where the BlockDevice's devPath may change unexpectedly after a node reboot or when the device is temporarily removed. The changes update the BlockDevice's status by reflecting the new devPath and activating an inactive device when it returns.
- Update the device path when a change is detected.
- Change the device state from Inactive to Active if applicable.
- Modify error handling by signaling the scanner upon update failure.
Vicente-Cheng
force-pushed
the
correct-status-dev-path
branch
from
9484915 to
09c128f
Compare
- when the node reboot, it might cause the device path change
because of the interrupt order with the device. We need to
update the device path once it changed.
Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
Vicente-Cheng
force-pushed
the
correct-status-dev-path
branch
from
09c128f to
6716553
Compare
|
@Mergifyio backport v1.5 |
✅ Backports have been created
|
tserong
approved these changes
May 8, 2025
|
@Mergifyio backport v0.7.x |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Sometimes we will see the duplicated status.deviceStatus.devPath of the blockdevice CR in the same node.
The device path would be change in following two cases:
So, we need to update the device path once it has changed
Solution:
Update device path once it has changed
Related Issue:
harvester/harvester#8164
Test plan:
Try to reboot, and you might see the spec.devPath is different from status.deviceStatus.devPath.
NOTE: It is hard to reproduce so that we can focus on the general use case, which should be kept the same.