Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: move drone to github action #101

Merged
merged 4 commits into from
May 16, 2024
Merged

ci: move drone to github action #101

merged 4 commits into from
May 16, 2024

Conversation

Vicente-Cheng
Copy link
Collaborator

Problem:
move image related work to github action

Solution:
migrate from drone to github

Related Issue:
harvester/harvester#5327

Test plan:
None

@Vicente-Cheng
ci: move drone to github action
924c2e1 
Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
@Vicente-Cheng Vicente-Cheng marked this pull request as ready for review May 9, 2024 08:21
@Vicente-Cheng Vicente-Cheng marked this pull request as draft May 9, 2024 08:46
@Vicente-Cheng Vicente-Cheng marked this pull request as ready for review May 9, 2024 08:56
@Vicente-Cheng
build: support aarch64/x86 build
65444d7 
    - Also use buildx instead docker to build image

Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
@Vicente-Cheng
README: update copyright
f129d7e 
Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
@Vicente-Cheng
build: remove dist
d0d5076 
    - NDM did not need this

Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
tserong
tserong approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@tserong tserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

(I wondered why this one didn't add a .github/workflows/pull_request.yaml like harvester/harvester-csi-driver#38 has, but then found we've already got .github/workflows/basic-ci.yaml which runs on a self-hosed runner, so it looks like the PR case is already handled)

@Vicente-Cheng
Copy link
Collaborator Author

LGTM!

(I wondered why this one didn't add a .github/workflows/pull_request.yaml like harvester/harvester-csi-driver#38 has, but then found we've already got .github/workflows/basic-ci.yaml which runs on a self-hosed runner, so it looks like the PR case is already handled)

yes, we already have the PR checking CI. It does more than just build, so I did not add .github/workflows/pull_request.yaml

bk201
bk201 approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bk201 bk201 merged commit aa45662 into harvester:master May 16, 2024
7 checks passed
@Vicente-Cheng
Copy link
Collaborator Author

@Mergifyio backport v0.5.x v0.6.x

@mergify Mergify
Copy link

mergify bot commented May 20, 2024 •
edited
Loading

backport v0.5.x v0.6.x

✅ Backports have been created

This was referenced May 20, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandboat brandboat brandboat left review comments

@tserong tserong tserong approved these changes

@bk201 bk201 bk201 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Vicente-Cheng @tserong @bk201 @brandboat