Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HEP: System robustness enhancement [CI SKIP] #4464

Closed
wants to merge 1 commit into from

Conversation

w13915984028
Copy link
Member

@w13915984028 w13915984028 commented Aug 29, 2023

IMPORTANT: Please do not create a Pull Request without creating an issue first.

HEP: System robustness enhancement

Signed-off-by: Jian Wang <w13915984028@gmail.com>

Problem:

How to gracefully shutdown an running Harvester cluster? no clear answer yet.

Solution:

Add to a new feature to accomplish this.

Related Issue:
#3261

One previous DOC PR: docs: add cluster shutdown and restart

Test plan:

@w13915984028 w13915984028 changed the title HEP: Gracefully Shutdown Harvester Cluster [CI SKIP] [WIP] HEP: Gracefully Shutdown Harvester Cluster [CI SKIP] Aug 29, 2023
@w13915984028
Copy link
Member Author

BTW: all review comments are welcome, thanks.

@vtrenton
Copy link

vtrenton commented Aug 29, 2023

Brainstorming:

  1. Shut down VMs using kube-virt graceful shutdown process: https://github.com/kubevirt/kubevirt/blob/main/docs/graceful-shutdown.md
  2. signal k8s to drain/cordon harvester node.
  3. assure all workloads like longhorn have been removed from the node
  4. shutdown node

oversimplifying a bit - but might be a good start.

Copy link

github-actions bot commented Nov 6, 2023

This repository uses an automated workflow to automatically label pull requests which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community pull requests better. If the pull request is still relevant, please add a comment to the pull request so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the pull request in 14 days. Thank you for your contributions.

@github-actions github-actions bot added the status/stale stale issue label label Nov 6, 2023
@github-actions github-actions bot closed this Nov 20, 2023
@markhillgit markhillgit reopened this Nov 20, 2023
@markhillgit
Copy link

reopening, this is still meant to be active

@github-actions github-actions bot removed the status/stale stale issue label label Nov 21, 2023
Copy link

This repository uses an automated workflow to automatically label pull requests which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community pull requests better. If the pull request is still relevant, please add a comment to the pull request so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the pull request in 14 days. Thank you for your contributions.

@github-actions github-actions bot added the status/stale stale issue label label Jan 21, 2024
@markhillgit
Copy link

ping, keeping this PR active

@github-actions github-actions bot removed the status/stale stale issue label label Jan 22, 2024
@w13915984028 w13915984028 removed the request for review from guangbochen January 22, 2024 18:35
@w13915984028 w13915984028 changed the title [WIP] HEP: Gracefully Shutdown Harvester Cluster [CI SKIP] [WIP] HEP: System robustness enhancement [CI SKIP] Jan 22, 2024
@w13915984028 w13915984028 changed the title [WIP] HEP: System robustness enhancement [CI SKIP] HEP: System robustness enhancement [CI SKIP] Feb 13, 2024
Signed-off-by: Jian Wang <w13915984028@gmail.com>
Copy link

This repository uses an automated workflow to automatically label pull requests which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community pull requests better. If the pull request is still relevant, please add a comment to the pull request so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the pull request in 14 days. Thank you for your contributions.

@github-actions github-actions bot added the status/stale stale issue label label Apr 15, 2024
@github-actions github-actions bot closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/stale stale issue label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants