leverage generateTemplates capability of harvester/addons #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@w13915984028 now that |
tserong
approved these changes
Jul 29, 2024
Yu-Jack
reviewed
Jul 30, 2024
Vicente-Cheng
approved these changes
Jul 30, 2024
Yu-Jack
approved these changes
Jul 30, 2024
|
@Mergifyio backport v1.4 |
✅ Backports have been created
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
PR introduces minor changes to installer to leverage the new
generateTemplatecapability added toharvester/addonsPrior to this change the addon updates were being managed by updates to version_info file, and also updating the version details in the rancher-22-addons.yaml template file.
Solution:
This has been simplified to use the chart versions in version_info file and allow ability to generate template file dynamically. This ensures that chart and image version change is only ever kept in one single location.
addons PR: harvester/addons#4
Related Issue:
harvester/harvester#4937
Test plan: