fix installer not initialising on arm hosts in equinix metal (backport #759) #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit 8ed87a5)
bk201
approved these changes
Jul 8, 2024
tserong
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Currently harvester installer does not initialise on arm instances on equinix metal.
The original arm implementation skipped the serial console /dev/ttyAMA0 in favour of non serial terminals exposed such as /dev/tty1 exposed on the ampere hosts.
Arm hosts in equinix metal only expose /dev/ttyAMA0 via serial-over-ssh. Since there is no alternate terminal exposed the installer does not start.
Solution:
The PR introduces a minor change to setup-installer script to favour non /dev/ttyAMA0 terminals if one is present such as on Ampere hosts, and failover to /dev/ttyAMA0 if that is the only option.
Related Issue:
Test plan:
This is an automatic backport of pull request #759 done by [Mergify](https://mergify.com).