Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Harvester management chart is modified (backport #701) #742

Merged
merged 1 commit into from
May 24, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented May 23, 2024

Problem:

Harvester ManagedChart is in modified status.

Solution:

Ignore the status fields on some Longhorn CRDs.

Related Issue:

harvester/harvester#5566

Test plan:

  • Create a new cluster.

  • Run kubectl get bundles -n fleet-local mcc-harvester, the BUNDLEDEPLOYMENTS-READY should be 1/1 and STATUS should be empty. For example:

    NAME            BUNDLEDEPLOYMENTS-READY   STATUS
    mcc-harvester   1/1
    

This is an automatic backport of pull request #701 done by [Mergify](https://mergify.com).

Ignore the status fields in some CRDs.

Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
(cherry picked from commit 65636ce)
Copy link
Contributor

@Vicente-Cheng Vicente-Cheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bk201 bk201 requested a review from ibrokethecloud May 23, 2024 14:34
Copy link
Contributor

@ibrokethecloud ibrokethecloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks.

@bk201 bk201 merged commit 27034ba into v1.3 May 24, 2024
5 checks passed
@mergify mergify bot deleted the mergify/bp/v1.3/pr-701 branch May 24, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants