enhancement: check default route during installation #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tserong
requested changes
May 6, 2024
tserong
approved these changes
May 6, 2024
w13915984028
reviewed
May 7, 2024
RKE2 requires a default route to work which is required during installation. The gateway setting will be checked in Static IP mode, but it could be absent in DHCP mode. Check the existence of the default route after applying network settings and stop the installation if no default route found. The check will be applied in both ISO and iPXE installation. Link: harvester/harvester#5675 Signed-off-by: Chris Chiu <chris.chiu@suse.com>
|
@w13915984028 @starbops revised per your suggestion. Thanks |
mingshuoqiu
added a commit
to mingshuoqiu/harvester-installer
that referenced
this pull request
May 17, 2024
RKE2 requires a default route to work which is required during installation. The gateway setting will be checked in Static IP mode, but it could be absent in DHCP mode. Check the existence of the default route after applying network settings and stop the installation if no default route found. The check will be applied in both ISO and iPXE installation. Link: harvester/harvester#5675 Signed-off-by: Chris Chiu <chris.chiu@suse.com> (cherry picked from commit 71247f7)
starbops
pushed a commit
that referenced
this pull request
May 20, 2024
RKE2 requires a default route to work which is required during installation. The gateway setting will be checked in Static IP mode, but it could be absent in DHCP mode. Check the existence of the default route after applying network settings and stop the installation if no default route found. The check will be applied in both ISO and iPXE installation. Link: harvester/harvester#5675 Signed-off-by: Chris Chiu <chris.chiu@suse.com> (cherry picked from commit 71247f7)
wombelix
added a commit
to wombelix/fork_harvester_harvester-installer
that referenced
this pull request
Jul 31, 2024
Revert changes: - harvester@71247f7 - harvester#725 Necessary to make installer for image creation functional again. Requires a permanent fix, e.g. a config flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
RKE2 requires a default route to start, some installations are stuck with no obvious message if there is no default route on the system.
Solution:
Check the existence of the default route after applying network settings and stop the installation if no default route found. The check will be applied in both ISO and iPXE installation.
Related Issue:
harvester/harvester#5675
Test plan:
option routers x.x.x.xNo default route foundmessage and stop the installationNo default route foundmessage.