Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: address action warnings #722

Merged
merged 1 commit into from
May 2, 2024
Merged

fix: address action warnings #722

merged 1 commit into from
May 2, 2024

Conversation

bk201
Copy link
Member

@bk201 bk201 commented May 2, 2024

@bk201
fix: address action warnings
b81d014 
Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
@bk201 bk201 changed the title fix: address actin warnings fix: address action warnings May 2, 2024
@bk201 bk201 marked this pull request as ready for review May 2, 2024 04:11
FrankYang0529
FrankYang0529 approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@FrankYang0529 FrankYang0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

ibrokethecloud
ibrokethecloud approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@ibrokethecloud ibrokethecloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks.

@bk201 bk201 merged commit c8ffa53 into harvester:master May 2, 2024
5 checks passed
@bk201
Copy link
Member Author

bk201 commented May 2, 2024

@Mergifyio backport v1.2 v1.3

@mergify Mergify
Copy link

mergify bot commented May 2, 2024 •
edited
Loading

backport v1.2 v1.3

✅ Backports have been created

This was referenced May 2, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankYang0529 FrankYang0529 FrankYang0529 approved these changes

@ibrokethecloud ibrokethecloud ibrokethecloud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bk201 @FrankYang0529 @ibrokethecloud