Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merge kernel parameters into global config #719

Merged
merged 1 commit into from
May 2, 2024

Conversation

bk201
Copy link
Member

@bk201 bk201 commented May 2, 2024

Signed-off-by: Kiefer Chang kiefer.chang@suse.com
(cherry picked from commit 8593ff8)

Problem:

The configs specified in the kernel parameters should be merged into installer config for the wipe disk feature to work.

Related Issue:

harvester/harvester#5174

Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
(cherry picked from commit 8593ff8)
Copy link
Contributor

@ibrokethecloud ibrokethecloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks.

@bk201 bk201 marked this pull request as ready for review May 2, 2024 02:54
@bk201 bk201 merged commit 972caf5 into harvester:v1.2 May 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants