-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add installation configure of LH GuaranteedInstanceManagerCPU #706
Conversation
@bk201 Kiefer suspect the CI failure may be related to harvester/harvester#5459, will double check with @FrankYang0529 Same failure is found in https://github.com/harvester/harvester-installer/actions/runs/8715101652/job/23906463527 |
@Mergifyio backport v1.2 v1.3 |
✅ Backports have been created
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
Signed-off-by: Jian Wang <w13915984028@gmail.com>
@bk201 The CI passed now. |
Problem:
Per harvester/harvester#5568
Solution:
Update source code and document
Related Issue:
harvester/harvester#5568
Test plan:
Create new cluster, use a harvester-configuration file (step 13 of https://docs.harvesterhci.io/v1.2/install/index) with below items, after installation, check the embedded LH, the related setting is as expected.
https://longhorn.io/docs/1.5.3/references/settings/#guaranteed-instance-manager-cpu
(valid values are in range [0..12], all other values are converted to 12)
LH chart:
** local test **
An expected value 3 of guaranteed-instance-manager-cpu is correctly set to LH via installation configure file.
config file
harvester saved config:
LH settings: