-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix grafana 404 in some scenarios #665
Conversation
@Mergifyio backport v1.3 |
❌ No backport have been created
GitHub error: |
NOTE PR for v1.2.2 #666 |
Do we need to co-author https://github.com/stalin4suse in the commit? |
12a32f5
to
180bdaa
Compare
Sure, at the time of commiting, did not have his info, now is updated. |
Signed-off-by: Jian Wang <w13915984028@gmail.com> Co-authored-by: Stalin Stepin <stalin.stepin@suse.com>
180bdaa
to
c0f7327
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. thanks.
I was able to re-produce the cluster by exploring the harvester 1.3.0-rc3 cluster via cluster explorer view in Rancher. The Cluster dashboard is unable to render the grafana content.
To test, patched the grafana-nginx-proxy-config
configmap in the cattle-monitoring-system
namespace, and delete the existing grafana pod.
Once grafana is running, cluster explorer is able to render the grafana dashboards.
Problem:
Grafana is not working in some scenairos.
Solution:
Add processing for all scenarios
This PR also includes all commits in #664
UI issue: harvester/harvester#5217, UI fix: harvester/dashboard#958
NOTE
In Harvester v1.2.1 & v1.2.2, there are some slightly differences in grafana, the PR and workaround will be made separately. DO NOT merge automatically. PR for v1.2.2: #666
Related Issue:
harvester/harvester#5221
Test plan:
Grafana can be both embedded in Harvester UI and opened in new UI window, and here are the full scenarios in Harvester.
A local Harvester cluster:
Rancher managed cluster:
Note:
In Rancher, virtualization management, the result is different when click the
link of cluster name
and clickManage
.Need to validate all them.