installer/config: add the role setup #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 18, 2024
bk201
reviewed
Jan 19, 2024
Vicente-Cheng
force-pushed
the
add-various-role-for-promote
branch
from
c79b9f7
to
0b40d92
Compare
bk201
reviewed
Jan 21, 2024
Now we support three roles `management`, `worker` and `witness`.
We need to add the related label to make promote controller
identify.
Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
Vicente-Cheng
force-pushed
the
add-various-role-for-promote
branch
from
0b40d92
to
f3fb77e
Compare
bk201
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
We tried to support various roles, so the installer need the related changes.
Solution:
Add an interactive part for role selection. Also, we need to add the related label for it.
Related Issue:
harvester/harvester#4786
Test plan:
We can check this feature with two parts as below.
workerrole on the second or third nodemanagementrole on the fifth node