Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer: reorder the patch operation for tty service #588

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

Vicente-Cheng
Copy link
Contributor

related issue: harvester/harvester#4648

@Vicente-Cheng Vicente-Cheng marked this pull request as draft November 1, 2023 14:45
@Vicente-Cheng Vicente-Cheng force-pushed the force-restart-the-tty-service branch 2 times, most recently from bcfa8dd to 8413b82 Compare November 3, 2023 08:50
@Vicente-Cheng Vicente-Cheng marked this pull request as ready for review November 3, 2023 08:53
@Vicente-Cheng Vicente-Cheng changed the title installer: force restart the ttys we reversed installer: reorder the patch operation for tty service Nov 3, 2023
Copy link

@jeff-radick-suse jeff-radick-suse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks OK to me

    We need guarantee the boot order like following:
    - `Patched tty service` -> `start tty service`

    So try to move the patch operation to the initramfs stage

Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, work great!

@bk201 bk201 merged commit 35dad50 into harvester:master Nov 24, 2023
6 checks passed
@bk201
Copy link
Member

bk201 commented Nov 24, 2023

@Mergifyio backport v1.2 v1.1

Copy link

mergify bot commented Nov 24, 2023

backport v1.2 v1.1

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants