Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor change to panel flow when machine has multiple disks #534

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

ibrokethecloud
Copy link
Contributor

Problem:

PR introduces a minor change to the installer to direct panel flow to password panel when node has multiple disks.

When multiple disks are present the disk choose page, after choosing the installation disk, the installer guides user to hostname panel even when install node is present.

Solution:

The PR changes the workflow when additional disks are present on the node.

Related Issue:

Test plan:

@masteryyh
Copy link
Contributor

masteryyh commented Jul 10, 2023

In my branch I merged installation disk and data disk, and this change seems not needed 🤔
https://github.com/masteryyh/harvester-installer/blob/a744bb185eea6dc6cbc8b68a1ad4af3aeb7d1662/pkg/console/install_panels.go#L457

Copy link
Contributor

@masteryyh masteryyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link
Contributor

@guangbochen guangbochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@bk201 bk201 merged commit 1ec4b01 into harvester:master Jul 11, 2023
@bk201
Copy link
Member

bk201 commented Jul 11, 2023

@Mergifyio backport v1.2

@mergify
Copy link

mergify bot commented Jul 11, 2023

backport v1.2

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants