Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix grafana dashboard 404 issue #512

Merged
merged 1 commit into from
Jun 21, 2023
Merged

fix grafana dashboard 404 issue #512

merged 1 commit into from
Jun 21, 2023

Conversation

w13915984028
Copy link
Member

@w13915984028 w13915984028 commented Jun 15, 2023 •
edited
Loading 

fix grafana dashboard 404 issue

Signed-off-by: Jian Wang <w13915984028@gmail.com>

Problem:

The grafana dashboard does not show correctly in local mode and rancher managed multi-cluster mode

Solution:

Config grafana nginx to generate appSubUrl dynamically.

Related Issue:
harvester/harvester#4087

The previous issue harvester/harvester#3780 and PR #492. Can work for local mode, but not for multi-cluster mode.

Test plan:

  1. install Harvester
  2. enable rancher-monitoring addon
  3. view cluster metrics, vm metrics from Harvester dashboard
  4. click grafana to open indepedent window
  5. import this Harvester into Rancher
  6. repeat 3 in Rancher
  7. repeat 4 in Rancher
    all should work

@w13915984028
fix grafana dashboard 404 issue
d6ed7ba 
Signed-off-by: Jian Wang <w13915984028@gmail.com>
@w13915984028 w13915984028 mentioned this pull request Jun 15, 2023
Closed
@DaiYuzeng DaiYuzeng mentioned this pull request Jun 16, 2023
Merged
@irishgordo irishgordo mentioned this pull request Jun 16, 2023
Closed
@guangbochen guangbochen requested review from bk201 and starbops and removed request for DaiYuzeng and WuJun2016 June 20, 2023 02:33
@guangbochen guangbochen mentioned this pull request Jun 20, 2023
Closed
guangbochen
guangbochen approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@guangbochen guangbochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

starbops
starbops approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@starbops starbops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and the Grafana dashboard showed correctly. LGTM, thanks!

bk201
bk201 approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bk201 bk201 merged commit 48f3dde into harvester:master Jun 21, 2023
@bk201
Copy link
Member

bk201 commented Jun 21, 2023

@Mergifyio backport v1.2

@mergify
Copy link

mergify bot commented Jun 21, 2023 •
edited
Loading

backport v1.2

✅ Backports have been created

@mergify mergify bot mentioned this pull request Jun 21, 2023
Merged
@w13915984028 w13915984028 deleted the fix4087 branch January 5, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bk201 bk201 bk201 approved these changes

@starbops starbops starbops approved these changes

@guangbochen guangbochen guangbochen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@w13915984028 @bk201 @starbops @guangbochen