-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support os.persistentStatePaths in Harvester configuration #459
Conversation
Signed-off-by: futuretea <Hang.Yu@suse.com>
|
@bk201 @guangbochen convert this PR to draft, try to add after-install-chroot in harvester-installer/pkg/config/cos.go Line 183 in 12eeb11
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Problem:
Currently, Harvester OS does not support custom paths for persistent storage or read-write paths. This means that any changes made to files not in default persistentStatePaths will be lost upon reboot.
Solution:
To address this issue, this pull request adds a new options to the Harvester OS configuration in Harvester config.
The
os.persistentStatePaths
option allows users to configure custom paths where modifications made to files will persist across reboots. This means that any changes made to files in these paths will not be lost upon reboot.an config example for install rook-ceph in Harvester
Without this PR, users can achieve the same effect by modifying
/oem/90_custom.yaml
and then rebootting. This PR allows users to define the desired os layout at installation time.Related Issue:
harvester/harvester#3688
Note
Please ensure that any custom paths added using these options are valid and secure, and that any modifications made to the OS are done with caution and understanding of the potential risks.
Test plan:
Refer to harvester/harvester#3566