Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Enable software-emulation for nested VMs #418

Merged
merged 1 commit into from
Feb 15, 2023
Merged

CI: Enable software-emulation for nested VMs #418

merged 1 commit into from
Feb 15, 2023

Conversation

bk201
Copy link
Member

@bk201 bk201 commented Feb 14, 2023 •
edited
Loading

Enable soft-emulation, the new kernel seems not to play well with the Equinix EPYC instance.

  • Set the configuration in KubeVirt CR. Do this in VM to avoid downloading kubectl.
spec:
  configuration:
    developerConfiguration:
      useEmulation: true
  • Update pinging code to a checking loop (timeout 5 minutes).

Related issue: harvester/harvester#3447

@bk201 bk201 force-pushed the wip-3447 branch 2 times, most recently from a239d26 to a8b166b Compare February 15, 2023 01:01
@bk201
CI: Enable software-emulation for nested VMs
38fd08c 
Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
@bk201 bk201 marked this pull request as ready for review February 15, 2023 04:56
Vicente-Cheng
Vicente-Cheng approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@Vicente-Cheng Vicente-Cheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this fixes

guangbochen
guangbochen approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@guangbochen guangbochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.
Additionally, it would be worth mentioning that we may need to consider allowing to pass overwritten values.yml to the Harvester chart.

@guangbochen guangbochen merged commit 20b97d3 into harvester:master Feb 15, 2023
@bk201 bk201 mentioned this pull request Feb 15, 2023
Merged
@Vicente-Cheng Vicente-Cheng mentioned this pull request Feb 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vicente-Cheng Vicente-Cheng Vicente-Cheng approved these changes

@guangbochen guangbochen guangbochen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bk201 @Vicente-Cheng @guangbochen