Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elemental: bump elemental-cli to v0.1.0 (backport #375) #398

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jan 3, 2023

This is an automatic backport of pull request #375 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Date Huang and others added 2 commits January 3, 2023 02:31
We cannot use Elemental-cli InstallSpec struct to generate config.yaml.
Because there are not all entry with "omitempty", it will cause
generated config.yaml will have several empty entry but didn't be
omitted.
Elemental-cli will treat those empty entry as user-specific value and
override the default value.

Use ElementalInstallSpec to ensure that all entry will be "omitempty".

Signed-off-by: Date Huang <date.huang@suse.com>
(cherry picked from commit cf08151)
Signed-off-by: Date Huang <tjjh89017@hotmail.com>
(cherry picked from commit 44cfcb1)
Copy link
Contributor

@Vicente-Cheng Vicente-Cheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@starbops starbops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bk201 bk201 merged commit 3d1f4c7 into v1.1 Jan 10, 2023
@mergify mergify bot deleted the mergify/bp/v1.1/pr-375 branch January 10, 2023 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants