Run "rke2-killall.sh" before shutdown #270
Conversation
package/harvester-os/files/etc/systemd/system/rke2-shutdown.service
Outdated
Show resolved
Hide resolved
| Before=reboot.target halt.target shutdown.target poweroff.target umount.target final.target | ||
|
|
||
| [Install] | ||
| RequiredBy=reboot.target halt.target shutdown.target poweroff.target umount.target final.target |
There was a problem hiding this comment.
Test and work well.
Is this unit required to be run after rke2-agent or rke2-server service is stopped?
There was a problem hiding this comment.
I feel like if it's a user that stopped the service, the user should decide whether rke2-killall.sh should be run.
There was a problem hiding this comment.
FWIW, I found some discussions about this issue, and seems like "stopping K3s/RKE2 does not stop running containers" is specifically designed to allow non-disruptive upgrade of K3s/RKE2.
There was a problem hiding this comment.
During an upgrade, we will always wait for RKE2 upgraded first and shut down later.
| [Service] | ||
| Type=oneshot | ||
| RemainAfterExit=yes | ||
| ExecStart=-/usr/local/bin/rke2-killall.sh |
There was a problem hiding this comment.
Also rke2-killall.sh sends KILL (-9) signals to processes, but rke2-server/agent's systemd services's ExecStopPost option sends TERM signals. Just wondering if it's safer to use TERM.
There was a problem hiding this comment.
using TERM might be a good idea to give the processes some time to clean up and terminate.
but we need to have another script to do it?
There was a problem hiding this comment.
Yes, using SIGTERM would be much safer. Do you think maybe we should create a copy of rke2-killall.sh and replace the -9 with -15?
There was a problem hiding this comment.
If that's oneliner, we can also embed it in the systemd unit file. There are many cleanups in the rke2-killall.sh script, maybe some are unnecessary.
Create a service to run script `rke2-killall.sh` to stop all the running containers. Signed-off-by: John Liu <john.liu@suse.com>
johnliu55tw
force-pushed
the
rke2-killall-before-shutdown
branch
from
28d5d53
to
1017d3c
Compare
|
Thanks, John. This was addressed in #480, so close it. |
Create a
rke2-shutdown.serviceto run scriptrke2-killall.shto stop all the running pods (containers) before system shutdown or reboot. One of the benefits is that system shutdown and reboot would be much faster.The key component is the
Before=umount.targetso that the service will runrke2-killall.shbefore systems started to unmount everything, including those Pods' volumes.Test plan
F12poweroffand the shutdown process would be blocked for around 1 minute. With this PR, those messages will not show at all.
rebootcommand or operation such as Press power button to initiate the graceful shutdown/reboot process, and they all shouldn't be affected by the message shown above.TODOs
rke2-shutdown.servicewill be installed and enabled.Related
rke2-shutdownservice is inspired by thesystemd-unit.txtprovided by the author of the issue