fixes based on pr review

harvester · Jul 6, 2023 · 1fc4eea · 1fc4eea
1 parent 3314631
commit 1fc4eea
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/pkg/config/config.go b/pkg/config/config.go
@@ -379,6 +379,7 @@ func GenerateRancherdConfig(config *HarvesterConfig) (*yipSchema.YipConfig, erro
 	if len(config.OS.NTPServers) > 0 {
 		runtimeConfig.TimeSyncd["NTP"] = strings.Join(config.OS.NTPServers, " ")
 		runtimeConfig.Systemctl.Enable = append(runtimeConfig.Systemctl.Enable, ntpdService)
+		runtimeConfig.Systemctl.Enable = append(runtimeConfig.Systemctl.Enable, timeWaitSyncService)
 	}
 	if len(config.OS.DNSNameservers) > 0 {
 		runtimeConfig.Commands = append(runtimeConfig.Commands, getAddStaticDNSServersCmd(config.OS.DNSNameservers))

diff --git a/pkg/console/util.go b/pkg/console/util.go
@@ -871,7 +871,6 @@ func applyRancherdConfig(ctx context.Context, g *gocui.Gui, hvstConfig *config.H
 	if err != nil {
 		return err
 	}
-	//defer os.Remove(liveCosConfig)
 
 	// apply live stage to configure node
 	err = apply(ctx, g, liveCosConfig, "live")
@@ -924,13 +923,11 @@ func generateEnvAndConfig(g *gocui.Gui, hvstConfig *config.HarvesterConfig) ([]s
 	if err != nil {
 		return nil, nil, err
 	}
-	//defer os.Remove(cosConfigFile)
 
 	hvstConfigFile, err := saveTemp(hvstConfig, "harvester")
 	if err != nil {
 		return nil, nil, err
 	}
-	//defer os.Remove(hvstConfigFile)
 
 	userDataUrl := hvstConfig.Install.ConfigURL
 	hvstConfig.Install.ConfigURL = cosConfigFile