Do a VM guest shut down if possible #762
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add info about `gracefulShutdown` and `gracefulShutdownTimeout`. Related to: harvester/harvester#7483 Signed-off-by: Volker Theile <vtheile@suse.com> (cherry picked from commit cf14b33) Signed-off-by: Volker Theile <vtheile@suse.com>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the VM importer documentation to describe the new graceful shutdown options when importing VMs.
- Adds two new fields, gracefulShutdown and gracefulShutdownTimeout, to the configuration example.
- Updates the documentation text to explain the behavior and default values for these fields and includes a note for OpenStack users.
|
jillian-maroket
approved these changes
Apr 23, 2025
ihcsim
approved these changes
Apr 23, 2025
|
Will turning the PR into a draft revert approvals? If not, I suggest making this a draft so people won't accidentally merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!!!!! DO NOT MERGE BEFORE harvester/vm-import-controller#69 !!!!!
Add info about
gracefulShutdownandgracefulShutdownTimeout.Related to: harvester/harvester#7483