Add new roles to node-disk-manager-webhook #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding new roles for: * longhorn.io - volumes/nodes/backingimages/replicas This is because incoming validation changes for the blockdevices introduce new caches which require those privileges Signed-off-by: Martin Dekov <martin.dekov@suse.com>
martindekov
force-pushed
the
diskremoval3344
branch
from
e9c6a55 to
d956c92
Compare
WebberHuang1118
approved these changes
Oct 23, 2025
Member
WebberHuang1118
left a comment
WebberHuang1118
left a comment
There was a problem hiding this comment.
LGTM, thanks.
By the way, the link to the test plan associated with the PR has been closed.
Contributor
Author
Good catch @WebberHuang1118, fixed ✔️ |
martindekov
added a commit
that referenced
this pull request
Oct 23, 2025
Adding new roles for: * longhorn.io - volumes/nodes/backingimages/replicas This is because incoming validation changes for the blockdevices introduce new caches which require those privileges Signed-off-by: Martin Dekov <martin.dekov@suse.com>
Vicente-Cheng
pushed a commit
that referenced
this pull request
Oct 23, 2025
Adding new roles for: * longhorn.io - volumes/nodes/backingimages/replicas This is because incoming validation changes for the blockdevices introduce new caches which require those privileges Signed-off-by: Martin Dekov <martin.dekov@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new roles for:
This is because incoming validation changes for the blockdevices introduce new caches which require those privileges
Problem:
In order to validate the statuses of backing images and volumes related with blockdevices we had to introduce caches in PR: harvester/node-disk-manager#244 where those permissions are required
Solution:
Add the permissions to the node-disk-manager-webhook's cluster role
Related Issue(s):
harvester/harvester#3344
Test plan:
In PR: harvester/node-disk-manager#248
Additional documentation or context
N/A