multi-root non-projective dependency crf with lengths mask #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great thanks for contributing. Sorry the repo is having some issues due to the travis. I will fix it up this week and add tests. |
…alculation. can be derived using minors and cofactors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I implement the feature as stated in title. The implementation basically follows section 3.3 of [1] with similar gradient update rules for marginals (like those in 3.2). I check marginals using the log-partition/marginals identity and they are the same. Let me know if anything needs to be improved!
[1] Structured Prediction Models via the Matrix-Tree Theorem. Koo et al. 2007.