support KL and cross-entropy semiring #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is so cool! Thanks for implementing. We probably should doc these a bit. Expectation semirings are tricky and seeing the implementation should be really helpful. Who is this btw? |
|
Yeah, I think cross-entropy and KL divergence semirings are extremely useful, it is very worthy to doc these a bit. I am Songlin Yang and I will be a first-grade postgraduate student in ShanghaiTech University in Sep. , I am very interested in structure prediction and computational linguistics.
…------------------ 原始邮件 ------------------
发件人: "Sasha Rush"<notifications@github.com>;
发送时间: 2020年7月30日(星期四) 晚上11:58
收件人: "harvardnlp/pytorch-struct"<pytorch-struct@noreply.github.com>;
抄送: "isomorphism"<406736650@qq.com>; "Author"<author@noreply.github.com>;
主题: Re: [harvardnlp/pytorch-struct] support KL and cross-entropy semiring (#79)
This is so cool! Thanks for implementing.
We probably should doc these a bit. Expectation semirings are tricky and seeing the implementation should be really helpful.
Who is this btw?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Very nice to meet you. Two very nice contributions in a hard area of structured prediction. Feel free to keep on editing the library or adding new parts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supporting KL and cross-entropy between two CRF distributions.
adding KL and cross-entropy semiring,
and add some test case for kl and cross-entropy