Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Jul 27, 2020

Python version of notebooks/BertDependencies.ipynb. Also fixed a small typo in the notebook on the below line:
incorrect_edges += (out[:, :].cpu() - gold[:, :].cpu()).abs().sum() / 2.0

Python version of notebooks/BertDependencies.ipynb
@srush
Copy link
Collaborator

srush commented Jul 29, 2020

Thanks! I haven't had the chance to make sure this achieves great performance. Do you have good numbers?

@srush srush merged commit d9157fc into harvardnlp:master Jul 29, 2020
@ghost ghost deleted the cactopi-patch-1 branch July 30, 2020 17:48
@ghost
Copy link
Author

ghost commented Jul 30, 2020

Sorry for the late reply—I did check that the script gets comparable numbers to the original notebook. Appreciate the notebooks, by the way. Very helpful to understand how to use the API in context of a model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant