Ensure Unix-style line endings. #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If people submit form data with line breaks in it, browsers may send those breaks as
\r\nrather than\n.This makes a material difference, now that we are using post snippets in the LIL blog: Jekyll looks for the first
\n\nto decide where to end the snippet, by default, and there doesn't appear to be a way to ask it to respect universal line endings.We are all on Macs anyway: I think if we force this to output with Unix-style line endings, we won't have any trouble.
We can consider adding a line-ending check in CI in the website-static repo too; TBD.