Merged
Conversation
hartwork
requested changes
Jun 13, 2025
Owner
hartwork
left a comment
hartwork
left a comment
There was a problem hiding this comment.
Hello @callmetango, here is what I found during review:
fetchcommandwrapper/__main__.py
Outdated
Comment on lines
+181
to
+182
| if os.getenv("NO_COLOR"): | ||
| args.append("--enable-color=false") |
Owner
There was a problem hiding this comment.
Move this into a separate commit please, it does not seem to have anything to do with portage verbosity.
fetchcommandwrapper/__main__.py
Outdated
|
|
||
| MAX_STREAMS = 5 | ||
| ARIA2_COMMAND = "/usr/bin/aria2c" | ||
| VERBOSE = os.getenv("PORTAGE_VERBOSE", "0") == "1" |
Owner
There was a problem hiding this comment.
Suggested change
| VERBOSE = os.getenv("PORTAGE_VERBOSE", "0") == "1" | |
| VERBOSE = os.getenv("PORTAGE_VERBOSE") == "1" |
Simpler and works the same.
* respect Portage verbosity setting * reduce standard verbosity
callmetango
force-pushed
the
feature/reduce-verbosity
branch
from
c38e9e3 to
d8e28fb
Compare
hartwork
changed the title
Owner
|
@callmetango PS: Should I go forward make a release or would you rather add |
Contributor
Author
|
Thank you for merging! I'd like to open another pull request regarding the NO_COLOR handling. After that is was nice to have a release. |
Owner
|
@callmetango cool, deal 🍻 |
Owner
|
@callmetango side note: I will bump the version to 1.0.0 because of the change in verbosity (a la semver). |
Owner
|
@callmetango done:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
respectNO_COLORenv variable