Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Finish and release v2.0.0 #92

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

WIP: Finish and release v2.0.0 #92

wants to merge 17 commits into from

Conversation

hartmantis
Copy link
Owner

@hartmantis hartmantis commented Jul 25, 2017 •
edited
Loading

What work remains to cut a v2 release?

  • What permissions should be used for the config files? At least in Ubuntu, the default clamd.conf and freshclam.conf have different ownership and different permissions.
  • Finish refactoring the initial update strategy. When should freshclam by run via an execute? When should Chef wait for it before proceeding?
  • Finish refactoring the old cron recipe into a scheduled scan custom resource.
  • Finish the clamav_addon resource, or make it just for clamav-milter and clamsmtpd if that's easier, (this could also wait for v2.1).
  • Finish re-adding Debian support and testing.
  • Finish adding back RHEL support. Note that RHEL7 has separate packages for systemd vs sysvinit support.
  • Add any other supported platform support and testing (Fedora?).
  • Update the README.
  • Fix the inevitable remaining build failures.

@hartmantis
Remove default helpers from the service resource
ced6365
@hartmantis
Remove default helpers from the app resource
32356e1
@hartmantis
Switch from storing defaults in methods to a DEFAULTS constant
4472ff3 
Otherwise we start polluting the resource namespaces with too many methods and
some collide with property names.
@hartmantis
Make the config resource default to the platform's default config
0ef04f1 
To start, for a "Debian" config, we've pulled the default config files off a
base Ubuntu 16.04 instance.
@hartmantis
Convert int tests to kitchen-dokken and Inspec
c102bc9
@hartmantis
Simplify the config resource's method_missing implementation
543bbec
@hartmantis
Update the year to 2017
4a81f94
@hartmantis
Fix some errors in the smoke tests
4ee15cc
@hartmantis
Do a config merge from the clamav to clamav_config resources
48863dc 
Also reorder operations so freshclam is ready before clamd is.
@hartmantis
Default the version to nil instead of latest
0fd31e5
@hartmantis
Speed up the build with multiple test suites and more .cvd hacking
4b33a66
@hartmantis
Unit test against both Ubuntu 16.04 and 14.04
8ea974b
@hartmantis
Wait for freshclam to update when first starting, but make it optional
0cc9ee2
@hartmantis
Define a helper resource for doing updates outside of the freshclam s…
15e2f1d 
…ervice
@hartmantis
Smoke test the update resource by using it as part of the build process
c3a740f
@hartmantis
Run clamav child resources in the parent run_context
8a57c1b 
This should make it easier to add custom notifications between the different
child resources, i.e. in a recipe that just does an `include_recipe 'clamav'`.
@hartmantis
Resolve all new style offenses
6c1e4ec
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6c1e4ec on jdh-v2.0 into ** on master**.

@mburns mburns mentioned this pull request Mar 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hartmantis @coveralls