Skip to content

Commit

Permalink
can: isotp: support MSG_TRUNC flag when reading from socket
Browse files Browse the repository at this point in the history
Upstream commit https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=42bf50a1795a

When providing the MSG_TRUNC flag via recvmsg() syscall the return value
provides the real length of the packet or datagram, even when it was longer
than the passed buffer.

Fixes: e057dd3fc20f ("can: add ISO 15765-2:2016 transport protocol")
Link: linux-can/can-utils#347 (comment)
Suggested-by: Derek Will <derekrobertwill@gmail.com>
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
  • Loading branch information
hartkopp committed Mar 17, 2022
1 parent 145ce8c commit f51b3b3
Showing 1 changed file with 16 additions and 13 deletions.
29 changes: 16 additions & 13 deletions net/can/isotp.c
Original file line number Diff line number Diff line change
Expand Up @@ -1042,33 +1042,32 @@ static int isotp_recvmsg(struct kiocb *iocb, struct socket *sock,
struct sock *sk = sock->sk;
struct sk_buff *skb;
struct isotp_sock *so = isotp_sk(sk);
int err = 0;
int noblock;
int noblock = flags & MSG_DONTWAIT;
int ret = 0;

noblock = flags & MSG_DONTWAIT;
flags &= ~MSG_DONTWAIT;
if (flags & ~(MSG_DONTWAIT | MSG_TRUNC))
return -EINVAL;

if (!so->bound)
return -EADDRNOTAVAIL;

skb = skb_recv_datagram(sk, flags, noblock, &err);
flags &= ~MSG_DONTWAIT;
skb = skb_recv_datagram(sk, flags, noblock, &ret);
if (!skb)
return err;
return ret;

if (size < skb->len)
msg->msg_flags |= MSG_TRUNC;
else
size = skb->len;

#if LINUX_VERSION_CODE >= KERNEL_VERSION(3,19,0)
err = memcpy_to_msg(msg, skb->data, size);
ret = memcpy_to_msg(msg, skb->data, size);
#else
err = memcpy_toiovec(msg->msg_iov, skb->data, size);
ret = memcpy_toiovec(msg->msg_iov, skb->data, size);
#endif
if (err < 0) {
skb_free_datagram(sk, skb);
return err;
}
if (ret < 0)
goto out_err;

sock_recv_timestamp(msg, sk, skb);

Expand All @@ -1077,9 +1076,13 @@ static int isotp_recvmsg(struct kiocb *iocb, struct socket *sock,
memcpy(msg->msg_name, skb->cb, msg->msg_namelen);
}

/* set length of return value */
ret = (flags & MSG_TRUNC) ? skb->len : size;

out_err:
skb_free_datagram(sk, skb);

return size;
return ret;
}

static int isotp_release(struct socket *sock)
Expand Down

0 comments on commit f51b3b3

Please sign in to comment.