Skip to content

Commit

Permalink
[fake autoscaler] remove the redundant mkdir (ray-project#47786)
Browse files Browse the repository at this point in the history
- docker compose service volume short syntax uses bind (similar to `-v`
and will create the dir if not exist
- the code was not mapping the dir to host path, so it actually has no
meaningful effect when it is running in a container, such as on CI

Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
  • Loading branch information
aslonnie authored Sep 23, 2024
1 parent cc984cd commit dde49e4
Showing 1 changed file with 0 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -57,14 +57,6 @@ def _update_docker_compose(
cmd = ["down"]
shutdown = True
try:
# Loop through parsed docker-compose and create node-specific
# host directories if needed
for node_id, node_conf in docker_compose_config["services"].items():
for volume_mount in node_conf["volumes"]:
host_dir, container_dir = volume_mount.split(":", maxsplit=1)
if container_dir == "/cluster/node" and not os.path.exists(host_dir):
os.makedirs(host_dir, 0o755, exist_ok=True)

subprocess.check_call(
["docker", "compose", "-f", docker_compose_path, "-p", project_name]
+ cmd
Expand Down

0 comments on commit dde49e4

Please sign in to comment.