Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape url to support idn domain names #116

Conversation

skammer
Copy link

@skammer skammer commented Jan 17, 2018

When I tried to download an archive of .рф website, I got an error:

Getting snapshot pages/usr/local/Cellar/ruby/2.4.1_1/lib/ruby/2.4.0/uri/rfc3986_parser.rb:21:in `split': URI must be ascii only "url follows"...

This PR seems to fix everything and I managed to successfully download an archive.

pabs3 added a commit to pabs3/wayback-machine-downloader that referenced this pull request May 3, 2021
This avoids problems related to URL encoding.

Obsoletes: hartator#116
@pabs3
Copy link
Contributor

pabs3 commented Jun 7, 2021

@hartator this issue has been fixed with version 2.3.0, I was able to download кц.рф fine, so please close this pull request. I do confirm that it does happen with version 2.2.1 though.

@hartator
Copy link
Owner

hartator commented Jun 7, 2021

Yes, that's right. 👍

@hartator hartator closed this Jun 7, 2021
0129general added a commit to 0129general/wayback-machine-downloader that referenced this pull request Dec 15, 2024
This avoids problems related to URL encoding.

Obsoletes: hartator/wayback-machine-downloader#116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants