Add support for cucumber 4

README.md

@@ -148,6 +148,6 @@ For Maintainers
 
 1. bump version
 1. `npm publish`
-1. tag release (`git tag v1.0.2 && git push origin master --tags`)
-1. build github release (`npm i -g release && release`)
+1. tag release (`git tag vx.x.x && git push origin master --tags`)
+1. build github release (`npx release`)
 

lib/resultsCapturer.js

@@ -14,6 +14,7 @@ switch (cucumberVersion) {
     break;
 
   case 3:
+  case 4:
     module.exports = eventListeners;
     break;
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "protractor-cucumber-framework",
-  "version": "4.1.1",
+  "version": "4.2.0",
   "description": "Protractor framework for Cucumber.js",
   "main": "index.js",
   "engines": {
@@ -11,7 +11,7 @@
     "start": "node test/testapp/server",
     "lint": "eslint . --fix",
     "pretest": "npm run lint && multidep test/multidep.js",
-    "test": "mocha -c -s 10000 -t 20000 test/**/*.spec.js"
+    "test": "mocha -c -s 10000 -t 30000 test/**/*.spec.js"
   },
   "repository": {
     "type": "git",
@@ -80,7 +80,8 @@
   "cucumberConf": {
     "version1": "1.3.3",
     "version2": "2.3.1",
-    "version3": "3.0.6"
+    "version3": "3.0.6",
+    "version4": "4.0.0"
   },
   "prettier": {
     "printWidth": 80,

test/cucumber/conf/cucumber4Conf.js

@@ -0,0 +1,11 @@
+let env = require('./environment.js');
+
+exports.config = Object.assign({}, env, {
+  cucumberOpts: {
+    require: '../stepDefinitions/**/cucumber4Steps.js',
+    tags: '',
+    format: 'summary',
+    strict: true,
+    'format-options': '{"colorsEnabled": false}'
+  }
+});

test/cucumber/features/cucumber4.feature

@@ -0,0 +1,6 @@
+Feature: Running Cucumber 4 with Protractor
+
+  @cucumber4
+  Scenario: Using Cucumber 4
+    Given I go on "index.html"
+    Then the title should equal "My AngularJS App"

test/cucumber/stepDefinitions/cucumber4Steps.js

@@ -0,0 +1,21 @@
+const path = require('path');
+const chai = require('chai');
+const chaiAsPromised = require('chai-as-promised');
+chai.use(chaiAsPromised);
+const expect = chai.expect;
+const {Given, Then} = require(path.join(
+  __dirname,
+  '..',
+  '..',
+  '..',
+  'lib',
+  'cucumberLoader'
+)).load();
+
+Given('I go on {string}', function(url) {
+  return browser.get(url);
+});
+
+Then(/the title should equal "([^"]*)"$/, function(text) {
+  return expect(browser.getTitle()).to.eventually.equal(text);
+});

test/cucumber4.spec.js

@@ -0,0 +1,16 @@
+let util = require('./test_util');
+
+describe('cucumber version 4', function() {
+  it('runs successful features', function() {
+    return util
+      .runOne(
+        'test/cucumber/conf/cucumber4Conf.js --cucumberOpts.tags @cucumber4'
+      )
+      .cucumberVersion4()
+      .expectExitCode(0)
+      .expectOutput('1 scenario (1 passed)')
+      .expectOutput('2 steps (2 passed)')
+      .expectErrors([])
+      .run();
+  });
+});

test/multidep.js

@@ -4,6 +4,6 @@ let conf = require(path.join(__dirname, '..', 'package.json')).cucumberConf;
 module.exports = {
   path: 'test/multidep_modules',
   versions: {
-    cucumber: [conf.version1, conf.version2, conf.version3]
+    cucumber: [conf.version1, conf.version2, conf.version3, conf.version4]
   }
 };

test/output-files.spec.js

@@ -34,7 +34,7 @@ describe('output files', () => {
     return util
       .runOne(cmd)
       .expectExitCode(0)
-      .after(() => expect(findLogFiles()).to.have.length(4)) //note: this will increase for every feature file we have
+      .after(() => expect(findLogFiles()).to.have.length(5)) //note: this will increase for every feature file we have
       .run();
   });
 
@@ -65,7 +65,7 @@ describe('output files', () => {
       .runOne(cmd)
       .cucumberVersion2()
       .expectExitCode(0)
-      .after(() => expect(findLogFiles()).to.have.length(4))
+      .after(() => expect(findLogFiles()).to.have.length(5))
       .run();
   });
 

test/test_util.js

@@ -40,6 +40,11 @@ let CommandlineTest = function(args) {
     return self;
   };
 
+  this.cucumberVersion4 = function() {
+    self.cucumberVesion_ = cucumberConf.version4;
+    return self;
+  };
+
   this.expectExitCode = function(exitCode) {
     self.expectedExitCode_ = exitCode;
     return self;