Skip to content

Commit

Permalink
update release build (aws-observability#50)
Browse files Browse the repository at this point in the history
*Issue #, if available:*

*Description of changes:*

* Re-enable the publishing to public/private ECR repos
* Add `registry-url` for node setup. Otherwise, you will get error in
`npx lerna publish` like this: `lerna ERR! E404 Not found`

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.
  • Loading branch information
pxaws authored Sep 12, 2024
1 parent f63f97e commit dd3a4e5
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 20 deletions.
1 change: 1 addition & 0 deletions .github/actions/set_up/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ runs:
uses: actions/setup-node@v4
with:
node-version: ${{ inputs.node_version }}
registry-url: 'https://registry.npmjs.org'

- name: Install dependencies and compile to build directory
shell: bash
Expand Down
40 changes: 20 additions & 20 deletions .github/workflows/release-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,27 +64,27 @@ jobs:
registry: public.ecr.aws


# # Publish to public ECR
# - name: Build and push public ECR image
# uses: docker/build-push-action@v5
# with:
# push: true
# context: .
# file: ./Dockerfile
# platforms: linux/amd64,linux/arm64
# tags: |
# ${{ env.RELEASE_PUBLIC_REPOSITORY }}:v${{ github.event.inputs.version }}
# Publish to public ECR
- name: Build and push public ECR image
uses: docker/build-push-action@v5
with:
push: true
context: .
file: ./Dockerfile
platforms: linux/amd64,linux/arm64
tags: |
${{ env.RELEASE_PUBLIC_REPOSITORY }}:v${{ github.event.inputs.version }}
# # Publish to private ECR
# - name: Build and push private ECR image
# uses: docker/build-push-action@v5
# with:
# push: true
# context: .
# file: ./Dockerfile
# platforms: linux/amd64,linux/arm64
# tags: |
# ${{ env.RELEASE_PRIVATE_REPOSITORY }}:v${{ github.event.inputs.version }}
# Publish to private ECR
- name: Build and push private ECR image
uses: docker/build-push-action@v5
with:
push: true
context: .
file: ./Dockerfile
platforms: linux/amd64,linux/arm64
tags: |
${{ env.RELEASE_PRIVATE_REPOSITORY }}:v${{ github.event.inputs.version }}
# Publish to GitHub releases
- name: Create GH release
Expand Down

0 comments on commit dd3a4e5

Please sign in to comment.