Skip to content

Commit

Permalink
PR Build Workflow - Ensure tests run on all specified Node versions (a…
Browse files Browse the repository at this point in the history
…ws-observability#14)

*Issue #, if available:*
Not seeing tests run in the GH workflow:

https://github.com/aws-observability/aws-otel-js-instrumentation/actions/runs/10322310931/job/28577248584

*Description of changes:*
Update workflow to run unit tests for all Node versions

*Testing:*

https://github.com/aws-observability/aws-otel-js-instrumentation/actions/runs/10322590525/job/28578137898?pr=14

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.
  • Loading branch information
jj22ee authored Aug 12, 2024
1 parent 2d59af7 commit c1398e1
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .github/workflows/pr-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ jobs:
fail-fast: false # ensures the entire test matrix is run, even if one permutation fails
matrix:
node: ["14", "16", "18", "20", "22"]
include:
- node: 18
code-coverage: true
env:
NPM_CONFIG_UNSAFE_PERM: true
steps:
Expand All @@ -36,7 +39,6 @@ jobs:
- name: Compile all NPM projects
run: npm run compile
- name: Unit tests (Full)
if: matrix.code-coverage
run: npm run test
- name: Report Coverage
if: ${{ matrix.code-coverage && !cancelled()}}
Expand Down

0 comments on commit c1398e1

Please sign in to comment.