Merge pull request #135 from fishcharlie/leapYear

Fix Leap Year Pattern
harrisiirak · Nov 7, 2018 · 45d1129 · 45d1129
2 parents 2e3f6db + eddb441
commit 45d1129
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/lib/expression.js b/lib/expression.js
@@ -73,7 +73,7 @@ CronExpression.constraints = [
  */
 CronExpression.daysInMonth = [
   31,
-  28,
+  29,
   31,
   30,
   31,
@@ -244,7 +244,7 @@ CronExpression._parseField = function _parseField (field, value, constraints) {
     stack.sort(function(a, b) {
       return a - b;
     });
-    
+
     return stack;
   }
 

diff --git a/test/leap_year.js b/test/leap_year.js
@@ -0,0 +1,17 @@
+var util = require('util');
+var test = require('tap').test;
+var expression = require('../lib/expression');
+
+test('leap year', function(t) {
+  try {
+    var interval = expression.parse('0 0 29 2 *');
+    var i;
+    var d;
+    for (i = 0; i < 20; ++i) {
+      d = interval.next();
+    }
+    t.end();
+  } catch (err) {
+    t.ifError(err, 'Interval parse error');
+  }
+});