Do a full overhaul of our tests in Avalonia

azure-pipelines.yml

@@ -20,26 +20,32 @@ jobs:
       Windows:
         imageName: 'windows-latest'
         targetFramework: 'net8.0-windows'
-  displayName: Build & Test
+  displayName: Build & Maybe Test
   pool:
     vmImage: $(imageName)
   steps:
   - checkout: self
     clean: true
-    
+
   - task: DotNetCoreCLI@2
     inputs:
       command: 'build'
       projects: $(Build.SourcesDirectory)/src/SerialLoops/SerialLoops.csproj
       arguments: -f $(targetFramework)
     displayName: Build project
 
+  - pwsh: |
+      Invoke-WebRequest -Uri https://haroohie.nyc3.cdn.digitaloceanspaces.com/bootstrap/serial-loops/test-assets.zip -OutFile $(Build.ArtifactStagingDirectory)/test-assets.zip
+      Expand-Archive -Path $(Build.ArtifactStagingDirectory)/test-assets.zip -DestinationPath $(Build.ArtifactStagingDirectory)/test-assets
+    displayName: Download test assets
+
   - task: DotNetCoreCLI@2
     inputs:
       command: 'test'
       projects: $(Build.SourcesDirectory)/test/SerialLoops.Tests.Headless/SerialLoops.Tests.Headless.csproj
-      arguments: -f $(targetFramework)
+      arguments: -f $(targetFramework) --filter "Name !~ BackgroundMusicEditor_ReplacementAndRestoreWork"
       publishTestResults: true
     env:
-      ROM_URI: $(ChokuRomUri)
-    displayName: Run tests
+      ASSETS_DIRECTORY: $(Build.ArtifactStagingDirectory)/test-assets/
+    displayName: Run tests
+    condition: eq(variables.imageName, 'windows-latest')

src/SerialLoops.Lib/Factories/ConfigFactory.cs

@@ -3,9 +3,7 @@
 using System.Globalization;
 using System.IO;
 using System.Runtime.InteropServices;
-using System.Security.Cryptography;
 using System.Text.Json;
-using DynamicData.Binding;
 using HaruhiChokuretsuLib.Util;
 
 namespace SerialLoops.Lib.Factories;

src/SerialLoops.Lib/Items/ItemDescription.cs

@@ -1,5 +1,4 @@
-using System;
-using System.Collections.Generic;
+using System.Collections.Generic;
 using System.Linq;
 using HaruhiChokuretsuLib.Archive.Event;
 using ReactiveUI;

src/SerialLoops.Lib/Items/PuzzleItem.cs

@@ -39,4 +39,4 @@ public override void Refresh(Project project, ILogger log)
         "KOIZUMI",
         "ANY",
     ];
-}
+}

src/SerialLoops.Lib/Items/ScriptItem.cs

@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.Data;
 using System.Linq;
 using HaruhiChokuretsuLib.Archive.Data;
 using HaruhiChokuretsuLib.Archive.Event;

src/SerialLoops.Lib/Project.cs

@@ -47,7 +47,7 @@ public partial class Project
     [JsonIgnore]
     public string ProjectFile => Path.Combine(MainDirectory, $"{Name}.{PROJECT_FORMAT}");
     [JsonIgnore]
-    public Config Config { get; private set; }
+    public Config Config { get; set; }
     [JsonIgnore]
     public ProjectSettings Settings { get; set; }
     [JsonIgnore]
@@ -1003,9 +1003,9 @@ public static (Project Project, LoadProjectResult Result) OpenProject(string pro
             }
             return (project, result);
         }
-        catch (Exception exc)
+        catch (Exception ex)
         {
-            log.LogError($"Error while loading project: {exc.Message}\n\n{exc.StackTrace}");
+            log.LogException(localize("Error while loading project"), ex);
             return (null, new(LoadProjectState.FAILED));
         }
     }
@@ -1328,4 +1328,4 @@ private bool ScriptIsInEpisode(ScriptItem script, int scenarioEpIndex, int scena
 
     [GeneratedRegex(@"\((?<num>\d+)\)")]
     private static partial Regex ProjectNameAppendedNumber();
-}
+}

src/SerialLoops.Lib/Script/ScriptItemCommand.cs

@@ -389,7 +389,7 @@ private static List<ScriptParameter> GetScriptParameters(ScriptCommandInvocation
                     }
                     break;
                 case CommandVerb.SCENE_GOTO:
-                case CommandVerb.SCENE_GOTO2:
+                case CommandVerb.SCENE_GOTO_CHESS:
                     if (i == 0)
                     {
                         parameters.Add(new ConditionalScriptParameter(localize("Scene"), eventFile.ConditionalsSection.Objects[parameter]));
@@ -750,4 +750,4 @@ public ScriptItemCommand Clone()
         };
     }
 
-}
+}

src/SerialLoops.Lib/SerialLoops.Lib.csproj

@@ -10,9 +10,9 @@
 
   <ItemGroup>
     <PackageReference Include="BunLabs.NAudio.Flac" Version="2.0.1" />
-    <PackageReference Include="HarfBuzzSharp.NativeAssets.Linux" Version="7.3.0.2" />
-    <PackageReference Include="HarfBuzzSharp.NativeAssets.macOS" Version="7.3.0.2" />
-    <PackageReference Include="HaruhiChokuretsuLib" Version="0.43.0" />
+    <PackageReference Include="HarfBuzzSharp.NativeAssets.Linux" Version="7.3.0.3" />
+    <PackageReference Include="HarfBuzzSharp.NativeAssets.macOS" Version="7.3.0.3" />
+    <PackageReference Include="HaruhiChokuretsuLib" Version="0.44.0" />
     <PackageReference Include="NAudio.Vorbis" Version="1.5.0" />
     <PackageReference Include="NitroPacker.Core" Version="2.5.1" />
     <PackageReference Include="NLayer" Version="1.16.0" />

src/SerialLoops.Lib/Util/Extensions.cs

@@ -81,7 +81,7 @@ public static string GetOriginalString(this string line, Project project)
     public static void CollectGarbage(this EventFile evt)
     {
         // Collect conditional garbage
-        IEnumerable<string> conditionalContainingCommands = new[] { CommandVerb.VGOTO, CommandVerb.SCENE_GOTO, CommandVerb.SCENE_GOTO2 }.Select(c => c.ToString());
+        IEnumerable<string> conditionalContainingCommands = new[] { CommandVerb.VGOTO, CommandVerb.SCENE_GOTO, CommandVerb.SCENE_GOTO_CHESS }.Select(c => c.ToString());
         List<UsedIndex> conditionalUsedIndices = [];
         foreach (ScriptCommandInvocation conditionalCommand in evt.ScriptSections.SelectMany(s => s.Objects).Where(c => conditionalContainingCommands.Contains(c.Command.Mnemonic)))
         {
@@ -294,4 +294,4 @@ public override SKColor Read(ref Utf8JsonReader reader, Type typeToConvert, Json
     }
 
     public override void Write(Utf8JsonWriter writer, SKColor value, JsonSerializerOptions options) => writer.WriteStringValue($"{value.Alpha:X2}{value.Red:X2}{value.Green:X2}{value.Blue:X2}");
-}
+}

src/SerialLoops.Lib/Util/WaveformRenderer/MaxPeakProvider.cs

@@ -1,5 +1,4 @@
 using System.Linq;
-using NAudio.Wave;
 
 // Adapted from https://github.com/naudio/NAudio.WaveFormRenderer/blob/master/WaveFormRendererLib/MaxPeakProvider.cs
 // Copyright (c) 2021 NAudio

src/SerialLoops/Assets/Strings.resx

@@ -2641,4 +2641,10 @@ No project is currently open. Would you like to create a new project?</value>
   <data name="Load Sound" xml:space="preserve">
     <value>Load Sound</value><comment>The name of a parameter for the SND_PLAY command which indicates whether a sound should be loaded or not</comment>
   </data>
+  <data name="&quot;Failed to open log file directly. Logs can be found at {0}&quot;" xml:space="preserve">
+    <value>"Failed to open log file directly. Logs can be found at {0}"</value>
+  </data>
+  <data name="Error while loading project" xml:space="preserve">
+    <value>Error while loading project</value>
+  </data>
 </root>

src/SerialLoops/Controls/ItemLink.axaml

@@ -5,5 +5,5 @@
              xmlns:controls="using:SerialLoops.Controls"
              mc:Ignorable="d" d:DesignWidth="800" d:DesignHeight="450"
              x:Class="SerialLoops.Controls.ItemLink">
-    <controls:LinkButton Name="Link" OnClick="Link_PointerPressed" Text="NONE" />
+    <controls:LinkButton Name="Link" Text="NONE" />
 </UserControl>