-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix drone filter func #2244
Fix drone filter func #2244
Conversation
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@bradrydzewski need you take this PR. I will write the blog post to introduce the drone filter feature. 👍 |
ping @bradrydzewski |
Hi @bradrydzewski can you take look at this? thanks. |
Without this the agent filter is broken, right? |
@tboerger Yes. |
@gvishnutej I don't have permission to merge this PR. I can verify this PR resolve the filter issue. |
sorry the delay on my end. I think eventually we will use a different (e.g. simpler) mechanism for routing jobs to different agents. So you should expect the filter to eventually be replaced, but that won't happen for a few months. |
@bradrydzewski Thanks for merging this fix. I see that |
@appleboy does this allow running certain jobs on certain agents? any quick example you could share, or link to a blog post? Been hoping for this feature! Thanks for your time on this! |
@geekdave see the @bradrydzewski comment #2200 (comment) |
* feat: [CDE-175]: Changing all shell commands from bash to sh.
As title. cc @bradrydzewski