Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix drone filter func #2244

Merged
merged 2 commits into from
Feb 19, 2018
Merged

Fix drone filter func #2244

merged 2 commits into from
Feb 19, 2018

Conversation

appleboy
Copy link

As title. cc @bradrydzewski

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@appleboy
Copy link
Author

@bradrydzewski need you take this PR. I will write the blog post to introduce the drone filter feature. 👍

@appleboy
Copy link
Author

ping @bradrydzewski

@appleboy
Copy link
Author

appleboy commented Jan 4, 2018

Hi @bradrydzewski can you take look at this? thanks.

@tboerger
Copy link

tboerger commented Jan 6, 2018

Without this the agent filter is broken, right?

@appleboy
Copy link
Author

appleboy commented Jan 6, 2018

@tboerger Yes.

@gvishnutej
Copy link

@tboerger @appleboy Any ETA when this PR will be merged? we want to use filter feature on drone agents

@appleboy
Copy link
Author

appleboy commented Feb 7, 2018

@gvishnutej I don't have permission to merge this PR. I can verify this PR resolve the filter issue.

@bradrydzewski
Copy link

sorry the delay on my end. I think eventually we will use a different (e.g. simpler) mechanism for routing jobs to different agents. So you should expect the filter to eventually be replaced, but that won't happen for a few months.

@bradrydzewski bradrydzewski merged commit 909053b into harness:master Feb 19, 2018
@appleboy appleboy deleted the fix2 branch February 20, 2018 02:21
@gvishnutej
Copy link

@bradrydzewski Thanks for merging this fix. I see that drone:latest docker image has this change. Is there a plan to release a new version of drone with this fix?

@geekdave
Copy link

@appleboy does this allow running certain jobs on certain agents? any quick example you could share, or link to a blog post? Been hoping for this feature! Thanks for your time on this!

@appleboy
Copy link
Author

@geekdave see the @bradrydzewski comment #2200 (comment)

bot2-harness pushed a commit that referenced this pull request Jul 19, 2024
* feat: [CDE-175]: Changing all shell commands from bash to sh.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants