Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFM-10366 - Delete events throwing ApiException exception #179

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

andybharness
Copy link
Contributor

FFM-10366 - Delete events throwing ApiException exception

What
Delete events don't need to call out to the server since they're only a notification to remove a flag/segment from local cache.

Why
When deleting a flag or target segment the following exception is seen:

io.harness.cf.ApiException:
	at io.harness.cf.ApiClient.handleResponse(ApiClient.java:1079)
	at io.harness.cf.ApiClient.execute(ApiClient.java:992)
	at io.harness.cf.api.ClientApi.getSegmentByIdentifierWithHttpInfo(ClientApi.java:1087)
	at io.harness.cf.api.ClientApi.getSegmentByIdentifier(ClientApi.java:1062)
	at io.harness.cf.client.connector.HarnessConnector.getSegment(HarnessConnector.java:334)
	at io.harness.cf.client.api.UpdateProcessor.lambda$processSegment$1(UpdateProcessor.java:124)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:833)

It is caused by a 404 being returned by the server

Testing
Manual + testgrid

What
Delete events don't need to call out to the server since they're only a notification to remove a flag/segment from local cache.

Why
When deleting a flag or target segment the following exception is seen:

io.harness.cf.ApiException:
	at io.harness.cf.ApiClient.handleResponse(ApiClient.java:1079)
	at io.harness.cf.ApiClient.execute(ApiClient.java:992)
	at io.harness.cf.api.ClientApi.getSegmentByIdentifierWithHttpInfo(ClientApi.java:1087)
	at io.harness.cf.api.ClientApi.getSegmentByIdentifier(ClientApi.java:1062)
	at io.harness.cf.client.connector.HarnessConnector.getSegment(HarnessConnector.java:334)
	at io.harness.cf.client.api.UpdateProcessor.lambda$processSegment$1(UpdateProcessor.java:124)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:833)

It is caused by a 404 being returned by the server

Testing
Manual + testgrid
Copy link
Contributor

@erdirowlands erdirowlands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andybharness andybharness merged commit 7ab0c7f into main Jan 5, 2024
3 of 4 checks passed
@andybharness andybharness deleted the FFM-10366-exception-on-delete-events branch January 5, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants