Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PL-Doc] Imp note for change in experimental permission to Active permission #9622

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ivikramsahu
Copy link
Collaborator

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.

Description

  • Please describe your changes: __________________________________
  • Jira/GitHub Issue numbers (if any): Ticket
  • Preview links/images (Internal contributors only): __________________

PR lifecycle

We aim to merge PRs within one week or less, but delays happen sometimes.

If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.

PRs must meet these requirements to be merged:

  • Successful preview build.
  • Code owner review.
  • No merge conflicts.
  • Release notes/new features docs: Feature/version released to at least one prod environment.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://67c9318a79bf20c1eb524ec0--harness-developer.netlify.app

:::Note
**Types of Permission**:

| **Status** | **Description** |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivikramsahu can we label the permissions listed in the page with their corresponding status?

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://67c95ff629bf7b30b8ee762b--harness-developer.netlify.app


If any automation relies on these `core_notification_view/edit/delete` permissions, we recommend updating them accordingly.

**Note:** The existing permissions are experimental and will be deprecated. The new permissions will be released in the **ACTIVE** state with RBAC enforced.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivikramsahu Can we add the exact timeline here? It's ambiguous right now.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @abhishekharness we cant have an exact timeline here it can be given based on releases

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to give 6 weeks of notice so accordingly we can get the timeline here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sahibaHarness A notice without any dates does not help the customer? We should have some dates based on releases.

|---------------------------------------------------|------------------------------------------------------------------------------------------------------------------------------|
| **Notifications Rules and Notification Channels** | <li>View (`core_notification_view`)</li><li>Edit (`core_notification_edit`)</li><li>Delete (`core_notification_delete`)</li> |

However, in an upcoming release, these permissions will become non-operational. They will be replaced with separate new permissions:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivikramsahu Can we add the exact timeline here? It's ambiguous right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants