Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating S3 cache doc and adding infra examples #953

Closed
wants to merge 4 commits into from

Conversation

jimsheldon
Copy link
Contributor

@jimsheldon jimsheldon commented Mar 10, 2023

DO NOT MERGE! This is a work in progress

Harness Developer Pull Request

Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.

What Type of PR is This?

  • Issue
  • Feature
  • Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

  • Issue(s)

House Keeping

Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

  • Tested Locally
  • Optional Screen Shoot.

Updating the S3 cache doc with updated information and infra examples

@jimsheldon jimsheldon changed the title initial changes Updating S3 cache doc and adding infra examples Mar 10, 2023
@ravilach ravilach requested a review from aimurphy March 10, 2023 20:33

This example pipeline demonstrates cache usage across two stages.

```mermaid
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bot-gitexp-user
Copy link

Preview environment: https://hdh.pr.harness.io/pr-953

@aimurphy aimurphy added DO NOT MERGE PR is not ready to be merged. work in progress labels Mar 10, 2023

:::

#### Linux/AMD64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would avoid going this far on heading levels. This would be better as just text in the body of the <details>.

I would argue the tabs are not necessary if you're going to put almost all (or all) of the content in the accordions. I would just use accordions then. you might also consider using tabs for "Single stage" and "multi stage". Then use an accordion for each build infra example.

Copy link
Contributor Author

@jimsheldon jimsheldon Mar 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem removing the heading.

There will be more than Linux/AMD64, we will probably have Linux/ARM64, Windows/AMD64, Mac/ARM64 and so on.

Linux and Mac might be identical, but I expect Windows to be different. Since we are already inside infrastructure tabs at this level, I am struggling with the best way to show this. Do users really need to see examples for every combination of OS/architecture? We also need to figure out how to show other languages than node.js... We can't have examples for every permutation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Providing an example for every permutation is probably not realistic - It would slow down docs work a lot. I would consider the real difference between them. Are they truly completely different or is it something like "sudo" vs "run as admin"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And also, is the value in showing the different languages or in showing the different platforms?

@bot-gitexp-user
Copy link

Preview environment: https://hdh.pr.harness.io/pr-953

@jimsheldon jimsheldon closed this Mar 16, 2023
@jimsheldon jimsheldon mentioned this pull request Mar 16, 2023
5 tasks
@ravilach ravilach deleted the s3-cache-doc-updates branch March 30, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE PR is not ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants